Skip to content

fix(scripts): tear down vite when the desktop dev window closes #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosspeili merged 2 commits into from
Aug 7, 2026
Merged

fix(scripts): tear down vite when the desktop dev window closes #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4523747
fix(scripts): stop dev:desktop leaving vite running after the window …
AUDOSt0ck1ng Aug 7, 2026
b746f27
docs: note dev:desktop concurrently -k teardown in changelog (#37, #38)
rosspeili Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

- Capture the Three.js group once in `VrmAvatar` so effect cleanup detaches from the same container the model was attached to (avoids orphan scenes on avatar swap). (#34)
- Drop unused `audioFile` prop from `VoicePanel` (file input is uncontrolled). (#34)
- `npm run dev:desktop` now passes `concurrently -k` so closing the Electron window (or killing Vite) tears down both processes and frees port 5173. (#37, #38)

## [0.5.0] — 2026-08-06

Expand Down
2 changes: 1 addition & 1 deletion avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"main": "electron/main.cjs",
"scripts": {
"dev": "vite",
"dev:desktop": "concurrently -n vite,electron -c cyan,magenta \"vite --port 5173 --strictPort\" \"wait-on http://localhost:5173 && cross-env VITE_DEV_SERVER_URL=http://localhost:5173 electron .\"",
"dev:desktop": "concurrently -n vite,electron -c cyan,magenta -k \"vite --port 5173 --strictPort\" \"wait-on http://localhost:5173 && cross-env VITE_DEV_SERVER_URL=http://localhost:5173 electron .\"",
"thumbs": "concurrently -n vite,electron -c cyan,magenta -k --success first \"vite --port 5174 --strictPort\" \"wait-on http://localhost:5174 && cross-env AVATAR_GEN_THUMBS=1 VITE_DEV_SERVER_URL=http://localhost:5174 electron .\"",
"desktop": "npm run build && cross-env NODE_ENV=production electron .",
"build": "vite build",
Expand Down