Implement manifest param validation and standardize outputs key - #253
Merged
Merged
Conversation
Add optional BaseSkill.validate_params() with jsonschema, reject legacy manifest output: in issuer tests, and align wallet_screening with outputs:. Fixes ARPAHLS#125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125 — optional manifest parameter validation and a single registry manifest cleanup.
BaseSkill.validate_params(), validates tool args against manifestparametersJSON Schema viajsonschema, raisesSkillwareParamValidationErroron mismatch. Not called by the loader orexecute(), opt-in for host apps.output:in registry manifests (useoutputs:with named keys).finance/wallet_screening,output:→outputs.report:.agent_loops.md,introduction.md, TESTING, CONTRIBUTING: validation optional, recommended beforeexecute()in agent loops.claude_wallet_check.py,gemini_tos_evaluator.pyshow the pattern.Type of Change
jsonschema>=4.0added to core dependenciesChecklist (all PRs)
Fixes #125)black --checkandflake8pass (Python 3.13)pytest tests/andpytest skills/pass (265 tests)CHANGELOG.mdupdated under[Unreleased]examples/README.md, no script add/rename/removepytest tests/test_registry_docs.py, agent-loops touched, matrix unchangedNew or updated skill
Minor manifest-only change to
finance/wallet_screening(outputs:key). No logic, tests, or catalog updates required for that skill.Related Issues
Fixes #125