-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate to allauth #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work overall, I left a handful of comments but nothing major:
- it would be nice to have either the user dropdown in the new settings or at least show the current user name when changing it (or both)
- I would add the license for the copied allauth templates
- for the github settings: please check if we need all scopes currently requested (or if that setting is even used). We should use the minimal scope necessary.
As already mentioned on Monday, quite a lot of the changed lines are due to reformatting (especially in the HTML files), which makes it harder to see the actual changes. I'll enable auto-formatting in the CI which should resolve at least basic reformattings, but for future PRs please also check the diff of your PR and try to only include necessary changes. If large scale reformatting of existing code is necessary, it might be better do that in a separate PR which doesn't change functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we show the current user name and/or show the account info in the bottom right corner in the settings menu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably not necessary as it's such a small part of their repo and you're already linking to it but I would copy over the license from
https://codeberg.org/allauth/django-allauth/src/branch/main/LICENSE and place it in templates/allauth/
| }, | ||
| }, | ||
| "github": { | ||
| "SCOPE": ["user", "repo", "gist", "notifications"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need access to the repo, gist, and notifications scope? It does not seem to actually access these (only "Access user email addresses (read-only)")

Warning
[Secrets] are not passed to workflows that are triggered by a pull request from a fork.so manual execution for the test is needed here. (They run fine locally on my machine)Note
Closes #67