Skip to content

Conversation

@plhrtr
Copy link
Collaborator

@plhrtr plhrtr commented Oct 29, 2025

Warning

  • As mentioned here [Secrets] are not passed to workflows that are triggered by a pull request from a fork. so manual execution for the test is needed here. (They run fine locally on my machine)
  • Removed the whole account_management django app
  • Added settings for theming and username in new Django app called user_settings, cause they are not handled by allauth
  • Settings are now at their own URLs. Slight decrease in user experience, as they must leave the site, but makes it easier to maintain and integrate the allauth settings
  • Project overview is now available at the root url
  • Restructered the settings.py file

Note

  • I removed the functionality to change the profile picture as it doesn't serve any purpose. But I could add it back in, if considered necassary. Maybe create default avatar with the first letter of the username and a random color. -> If so create new issue for that

Closes #67

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 29, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@plhrtr plhrtr requested a review from lisannengel October 31, 2025 09:26
@plhrtr plhrtr marked this pull request as ready for review October 31, 2025 09:26
@lisannengel lisannengel requested a review from fluegelk November 5, 2025 12:26
Copy link
Collaborator

@lisannengel lisannengel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Copy link
Collaborator

@fluegelk fluegelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall, I left a handful of comments but nothing major:

  • it would be nice to have either the user dropdown in the new settings or at least show the current user name when changing it (or both)
  • I would add the license for the copied allauth templates
  • for the github settings: please check if we need all scopes currently requested (or if that setting is even used). We should use the minimal scope necessary.

As already mentioned on Monday, quite a lot of the changed lines are due to reformatting (especially in the HTML files), which makes it harder to see the actual changes. I'll enable auto-formatting in the CI which should resolve at least basic reformattings, but for future PRs please also check the diff of your PR and try to only include necessary changes. If large scale reformatting of existing code is necessary, it might be better do that in a separate PR which doesn't change functionality.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we show the current user name and/or show the account info in the bottom right corner in the settings menu?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably not necessary as it's such a small part of their repo and you're already linking to it but I would copy over the license from
https://codeberg.org/allauth/django-allauth/src/branch/main/LICENSE and place it in templates/allauth/

},
},
"github": {
"SCOPE": ["user", "repo", "gist", "notifications"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need access to the repo, gist, and notifications scope? It does not seem to actually access these (only "Access user email addresses (read-only)")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to allauth

3 participants