Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat reveal fix #30

Open
wants to merge 181 commits into
base: master
Choose a base branch
from
Open

Feat reveal fix #30

wants to merge 181 commits into from

Conversation

youyix
Copy link
Contributor

@youyix youyix commented Jan 22, 2016 •
edited by VincenzoFerme
Loading

Now this branch has been rebased on master.

@VincenzoFerme
Merge branch 'devel' into feat-dockerize
6cc0893
@VincenzoFerme
Ready for Node.js cluster feature
7c393d8
@VincenzoFerme
Wrongly committed files
4809c23
@VincenzoFerme
Ready for cluster feature of Node.JS
dc7b5e1
@VincenzoFerme
Fixed typo
3da844c
@VincenzoFerme
Added Dockerfiles and configurations
dc52356
@VincenzoFerme
Updated dependencies for a correct build
339d8fa
@VincenzoFerme
Added Dockerfile for test and travis configuration using docker
691ba32
@VincenzoFerme
Updated travis to the new infrastructure
3f6ee29
@VincenzoFerme
Added docker service
eff3b63
@VincenzoFerme
Updated to sudo: required
03ead5b
@VincenzoFerme
Updated to use a directory as context of the test Dockerfile
33b4a50
@VincenzoFerme
Updated to Dockerfile.test
5f867d0
@VincenzoFerme
Updated test command
2c444c2
@VincenzoFerme
Removed kerberos
4beb732
@VincenzoFerme
Added kerberos back
12b683d
@VincenzoFerme
Improved Docker Container Settings
69f1334
@VincenzoFerme
Added bower cache clean on install
fda6aaf
@VincenzoFerme
Enabled sudo for bower cache clean
d5bc3e8
@VincenzoFerme @triglian
Ready for Node.js cluster feature
069c1c8
@VincenzoFerme @triglian
Wrongly committed files
c3ff63d
@VincenzoFerme @triglian
Ready for cluster feature of Node.JS
f394a8d
@VincenzoFerme @triglian
Fixed typo
37e415a
@VincenzoFerme @triglian
Added Dockerfiles and configurations
bb6ed8c
@VincenzoFerme @triglian
Updated dependencies for a correct build
d3325e6
@VincenzoFerme @triglian
Added Dockerfile for test and travis configuration using docker
d6ff71d
@VincenzoFerme @triglian
Updated travis to the new infrastructure
ed896c6
@VincenzoFerme @triglian
Added docker service
72024a2
@VincenzoFerme @triglian
Updated to sudo: required
911a28d
@VincenzoFerme @triglian
Updated to use a directory as context of the test Dockerfile
35eb970
@triglian
Copy link
Member

triglian commented May 8, 2016 •
edited by youyix
Loading

It's good if we have the following:

  • As less patching of reveal.js as possible: we should try to use it's configuration as much as possible.
  • The viewer/presenter configurations should happen by ASQ, the author of the presentation shouldn't be responsible for including asq-reveal-initiator.js.
  • tests for:
    1. viewers shouldn't see the reveal's preview view.
    2. viewers shouldn't be able to move the presentation back and forth with the keys.
    3. viewers shouldn't be able to change window.location and force navigation to an unauthorised slide.

triglian added 16 commits May 9, 2016 15:45
@triglian
remove visualization manager
beb61d4
@triglian
Merge branch 'master' of github.com:ASQ-USI/ASQ
f93ef48
@triglian
remove casper
878a378
@triglian
Upload: Add drag and drop functionality. Add title field
93dab1f 
 - Add drag and drop upload functionality with Dropzone.js
 - Add Title field for presentation
 - Update styles
 - Add nightwatch tests
 - Add loginUser and DragAndDropFile nightwatch commands
@triglian
nightwatch: ignore custom commands and edit
a1ee8fd
@triglian
Merge pull request #61 from ASQ-USI/feat-pname-form
3a3ab42 
Add drag and drop upload form and title field
@triglian
require dropzone with the right name
d970d63
@triglian
fix typo
d0c32f4
@triglian
Merge pull request #62 from ASQ-USI/fix-dropzone-dep
872544e 
Fix dropzone dependency problem
@triglian
make sure proxy returns a new instance of settings
f4ac6f7
@triglian
update deps
2b3c169
@triglian
Merge pull request #63 from ASQ-USI/fix-proxy-settings
7370d8d 
Fix proxy settings
@triglian
ghost: fix presentationframework and add events
cd70058
@triglian
Merge pull request #66 from ASQ-USI/fix-ghost-client
aa45267 
ghost: fix presentationframework and add events
@triglian
client/elements don't use /deep/
0bf8be1
@triglian
don't blacklist smartphones, they are stronger now
f4f9b9e
@youyix
Copy link
Contributor Author

youyix commented Jul 7, 2016

As less patching of reveal.js as possible: we should try to use it's configuration as much as possible.

The current implementation only relies on asq-reveal-initiator.js.

@youyix
Copy link
Contributor Author

youyix commented Jul 7, 2016 •
edited
Loading

tests for:
i. viewers shouldn't see the reveal's preview view.
ii. viewers shouldn't be able to move the presentation back and forth with the keys.
iii. viewers shouldn't be able to change window.location and force navigation to an unauthorised slide.

In current implementation, viewers

  1. are not able to see preview view (and also any other control mode)
  2. couldn't move the presentation back and forth with keys
  3. (fixed) couldn't not view an unauthorized slide by changing the hash

@youyix
Copy link
Contributor Author

youyix commented Jul 7, 2016

which branch should I do the rebase?

@triglian
Copy link
Member

triglian commented Jul 7, 2016

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youyix @triglian @VincenzoFerme