[REFACTOR/#229] 1차 리팩(1/4회의 수정사항 반영 완료)#230
Merged
Conversation
2ghrms
approved these changes
Jan 19, 2026
Member
2ghrms
left a comment
There was a problem hiding this comment.
고생하셨습니다~~ PR 제목의 키워드만 대문자로 수정하면 좋을 것 같아요~
src/main/java/com/assu/server/domain/user/service/StudentServiceImpl.java
Show resolved
Hide resolved
| } | ||
|
|
||
|
|
||
| public static PaperContentResponseDTO toContentResponse(PaperContent content) { |
Member
There was a problem hiding this comment.
converter를 더이상 사용하지 않기로 했으니 convert 관련 로직은 해당 DTO 내부로 옮기면 될 것 같습니다~
Contributor
Author
There was a problem hiding this comment.
아 근데 약간 애매한게 이게 dto를 entity로 바꾸는게 아니라 서비스 로직 내부에서 그냥 이거저거 다 모아서 paper를 만드는거라서.. 이걸 dto 내부 로직으로 옮길 수는 없을 것 같고 아니면 그냥 serivce 로직 내부에서 전환하는 형식으로 해야할 것 같은데 뭐가 더 나으려나요...?
Member
There was a problem hiding this comment.
PaperContentResponseDTO 내부에 static 메소드로 선언후에 서비스단에서 호출하면 될 것 같습니다~~
src/main/java/com/assu/server/domain/certification/component/CertificationSessionManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/certification/service/CertificationServiceImpl.java
Show resolved
Hide resolved
src/main/java/com/assu/server/domain/certification/service/CertificationServiceImpl.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명(스크린샷(선택))
비고 (Optional)
[API 설명]
임시 QR 데이터 생성 API
단순하게 userId, storeId (+고유 id) 로 구성된 테이블을 하나 뺐고 연관관계는 맺지 않았습니다. 단순 id 참조 방식으로 했어요 임시적인 방법이라서 나중에 언제든지 테이블을 날려 버릴 수 있게 구성했습니다.
스탬프 증가 API
기존에는 대시보드에 사용 내역을 넣어주면서 동시에 해당 유저들의 스탬프를 하나씩 증가시켰었는데 이번에 임시 운영에서는 단순하게 리뷰 작성, 제휴 건의 이후에 스템프만 증가하는 거라서 따로 하나 만들었습니다.