-
Notifications
You must be signed in to change notification settings - Fork 2
[REFACTOR/#232] Notification, ProfileImage, Inquiry 수정 #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
86469c2
[REFACTOR/#232] DeviceToken 리팩토링
leesumin0526 81da74c
[REFACTOR/#232] Inquiry, ProfileImage 분리 및 리팩토링
leesumin0526 ce56fe8
[REFACTOR/#232] Map 프로필 이미지 null 처리 추가
leesumin0526 8638d91
[REFACTOR/#232] Notification 리팩토링
leesumin0526 54f5370
[MOD/#232] JwtAuthFilter 수정사항 Rollback
leesumin0526 eb246b0
[REFACTOR/#232]
leesumin0526 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/main/java/com/assu/server/domain/common/dto/PageResponseDTO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package com.assu.server.domain.common.dto; | ||
|
|
||
| import org.springframework.data.domain.Page; | ||
| import java.util.List; | ||
|
|
||
| public record PageResponseDTO<T>( | ||
| List<T> items, | ||
| int page, | ||
| int size, | ||
| int totalPages, | ||
| long totalElements | ||
| ) { | ||
| public static <T> PageResponseDTO<T> of(Page<T> page) { | ||
| return new PageResponseDTO<>( | ||
| page.getContent(), | ||
| page.getNumber() + 1, | ||
| page.getSize(), | ||
| page.getTotalPages(), | ||
| page.getTotalElements() | ||
| ); | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
src/main/java/com/assu/server/domain/deviceToken/service/DeviceTokenService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| package com.assu.server.domain.deviceToken.service; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public interface DeviceTokenService { | ||
| Long register(String tokenId, Long memberId); | ||
| Long register(String token, Long memberId); | ||
| void unregister(Long tokenId, Long memberId); | ||
| void deactivateTokens(List<String> invalidTokens); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 0 additions & 18 deletions
18
src/main/java/com/assu/server/domain/inquiry/converter/InquiryConverter.java
This file was deleted.
Oops, something went wrong.
10 changes: 4 additions & 6 deletions
10
src/main/java/com/assu/server/domain/inquiry/dto/InquiryAnswerRequestDTO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| package com.assu.server.domain.inquiry.dto; | ||
|
|
||
| import jakarta.validation.constraints.NotBlank; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class InquiryAnswerRequestDTO { | ||
| @NotBlank(message = "answer는 비어 있을 수 없습니다.") | ||
| private String answer; | ||
| } | ||
| public record InquiryAnswerRequestDTO ( | ||
| @NotBlank(message = "answer는 비어 있을 수 없습니다.") | ||
leesumin0526 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| String answer | ||
| ) {} | ||
24 changes: 13 additions & 11 deletions
24
src/main/java/com/assu/server/domain/inquiry/dto/InquiryCreateRequestDTO.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| package com.assu.server.domain.inquiry.dto; | ||
| import lombok.*; | ||
|
|
||
| @Getter | ||
| @Setter | ||
| @NoArgsConstructor | ||
| @AllArgsConstructor @Builder | ||
| public class InquiryCreateRequestDTO { | ||
| private String title; | ||
| private String content; | ||
| private String email; | ||
| } | ||
|
|
||
| import jakarta.validation.constraints.NotBlank; | ||
|
|
||
| public record InquiryCreateRequestDTO ( | ||
| @NotBlank(message = "title은 비어 있을 수 없습니다.") | ||
| String title, | ||
|
|
||
| @NotBlank(message = "content는 비어 있을 수 없습니다.") | ||
| String content, | ||
|
|
||
| @NotBlank(message = "email은 비어 있을 수 없습니다.") | ||
| String email | ||
| ){ } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.