-
Notifications
You must be signed in to change notification settings - Fork 90
Migrate supportData to on-demand fetching with Pooch #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ReeceHumphreys
wants to merge
16
commits into
develop
Choose a base branch
from
feature/pooch
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7914eec to
ad9ee1d
Compare
ad9ee1d to
da91cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an effort to reduce the size of basilisks wheels and shift to a more sustainable long term architecture it is desirable to not ship support data files inside the wheels. As such, we need a mechanism to fetch and cache files on demand as they are requested.
If you clone the repo most of the data is still provided directly. As before, some data such as JPL Spice data was downloaded during the build. With this branch such Spice data will now also be downloaded on demand.
To accomplish this, the way data files are loaded and used in bsk has changed drastically and now leverages Pooch to handle fetching the files. This is a library that has been battle tested by many other popular Python scientific libraries for similar reasons.
As such, this PR does the following:
bskLargeDatacommand to prefetch all dynamic data componentsVerification
CI/CD and local testing of newly built wheels verify that they do not contain the supportData files and can fetch the files using the new API.
Documentation
Future work
N/A