Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in DG and website links #246

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

hjuntan
Copy link

@hjuntan hjuntan commented Apr 13, 2024

No description provided.

@hjuntan hjuntan changed the title Changes to model in DG Changes in DG and website links Apr 13, 2024
@@ -130,7 +130,7 @@ The `Model` component,

<box type="info" seamless>

**Note:** An alternative (arguably, a more OOP) model is given below. It has a `Group` list in the `AddressBook`, which `Person` references. This allows `AddressBook` to only require one `Group` object per unique tag, instead of each `Person` needing their own `Tag` objects.<br>
**Note:** An alternative (arguably, a more OOP) model is given below. It has a `Group` list in the `AddressBook`, which `Person` references. This allows `AddressBook` to only require one `Group` object per unique group, instead of each `Person` needing their own `Group` objects. It also includes hiding the `Remark` in the `Schedule` class to ensure more OOP-ness.<br>
Copy link

@cheahTJ cheahTJ Apr 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification, what do you mean by It also includes hiding the Remark in the Schedule class to ensure more OOP-ness?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because right now the person has a remark class; to ensure more encapsulation, we can put the remark with the schedule as it makes more sense: Each schedule has a remark; and we can use it to add more schedules i.e. each Person can have multiple Schedules that have its own Remark

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okayy I got your point. Maybe can rephrase it as such: Additionally, a remark can also be encapsulated in the Schedule class to ensure more OOP-ness by allowing each Person to have multiple Schedules with its corresponding Remark.

@cheahTJ cheahTJ merged commit 6611662 into AY2324S2-CS2103T-T15-2:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants