Skip to content

Commit

Permalink
Add logging to modifying commands
Browse files Browse the repository at this point in the history
  • Loading branch information
yisiox committed Apr 15, 2024
1 parent 87c542b commit 9e2e174
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/main/java/seedu/address/logic/commands/AddCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@
import static seedu.address.model.person.fields.Phone.PREFIX_PHONE;
import static seedu.address.model.person.fields.Tags.PREFIX_TAG;

import java.util.logging.Logger;
import java.util.stream.Stream;

import seedu.address.commons.core.LogsCenter;
import seedu.address.commons.util.ToStringBuilder;
import seedu.address.logic.Messages;
import seedu.address.logic.commands.exceptions.CommandException;
Expand Down Expand Up @@ -53,6 +55,8 @@ public class AddCommand extends Command {
public static final String MESSAGE_SUCCESS = "New contact added: %1$s";
public static final String MESSAGE_DUPLICATE_CONTACT = "This contact already exists.";

private static final Logger logger = LogsCenter.getLogger(AddCommand.class);

private final Person toAdd;

/**
Expand All @@ -68,6 +72,7 @@ public String execute(Model model) throws CommandException {
requireNonNull(model);

if (model.hasPerson(toAdd)) {
logger.finer("Recognized as duplicate person: " + toAdd.toString());
throw new CommandException(MESSAGE_DUPLICATE_CONTACT);
}

Expand Down
6 changes: 6 additions & 0 deletions src/main/java/seedu/address/logic/commands/AssetCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
import static seedu.address.commons.util.CollectionUtil.requireAllNonNull;
import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT;

import java.util.logging.Logger;
import java.util.stream.Stream;

import seedu.address.commons.core.LogsCenter;
import seedu.address.commons.util.ToStringBuilder;
import seedu.address.logic.commands.exceptions.CommandException;
import seedu.address.logic.util.ArgumentMultimap;
Expand Down Expand Up @@ -33,6 +35,8 @@ public class AssetCommand extends Command {
public static final String MESSAGE_NOT_EDITED = "At least one field to edit must be provided.";
public static final String MESSAGE_INVALID_ASSET_NAME = "The asset name provided is invalid";

private static final Logger logger = LogsCenter.getLogger(AssetCommand.class);

private final Asset target;
private final Asset editedAsset;

Expand All @@ -52,9 +56,11 @@ public String execute(Model model) throws CommandException {
requireNonNull(model);

if (target.equals(editedAsset)) {
logger.finer("Asset recognized as unedited: " + editedAsset);
throw new CommandException(MESSAGE_NOT_EDITED);
}
if (!model.hasAsset(target)) {
logger.finer("Asset recognized as non-existing: " + editedAsset);
throw new CommandException(MESSAGE_INVALID_ASSET_NAME);
}

Expand Down
10 changes: 10 additions & 0 deletions src/main/java/seedu/address/logic/commands/CopyCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
import static seedu.address.model.person.fields.Tags.PREFIX_TAG;

import java.util.List;
import java.util.logging.Logger;

import seedu.address.commons.core.LogsCenter;
import seedu.address.commons.core.index.Index;
import seedu.address.commons.util.ToStringBuilder;
import seedu.address.logic.Messages;
Expand Down Expand Up @@ -42,6 +44,8 @@ public class CopyCommand extends Command {
public static final String MESSAGE_NO_PARAM = "One field to copy must be provided.";
public static final String MESSAGE_EXTRA_PARAM = "Only one field can be copied.";

private static final Logger logger = LogsCenter.getLogger(CopyCommand.class);

private final Index index;
private final boolean[] info;

Expand Down Expand Up @@ -78,21 +82,27 @@ private static String copyToClipboard(Person personToCopy, boolean[] info) {
requireNonNull(personToCopy);

if (info[0]) {
logger.finest("Copied name to clipboard");
return personToCopy.getName().toString();
}
if (info[1]) {
logger.finest("Copied phone to clipboard");
return personToCopy.getPhone().toString();
}
if (info[2]) {
logger.finest("Copied email to clipboard");
return personToCopy.getEmail().toString();
}
if (info[3]) {
logger.finest("Copied address to clipboard");
return personToCopy.getAddress().toString();
}
if (info[4]) {
logger.finest("Copied tags to clipboard");
return personToCopy.getTags().toString();
}
if (info[5]) {
logger.finest("Copied assets to clipboard");
return personToCopy.getAssets().toString();
}

Expand Down
5 changes: 5 additions & 0 deletions src/main/java/seedu/address/logic/commands/EditCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.logging.Logger;

import seedu.address.commons.core.LogsCenter;
import seedu.address.commons.core.index.Index;
import seedu.address.commons.util.CollectionUtil;
import seedu.address.commons.util.ToStringBuilder;
Expand Down Expand Up @@ -59,6 +61,8 @@ public class EditCommand extends Command {
public static final String MESSAGE_NOT_EDITED = "At least one field to edit must be provided.";
public static final String MESSAGE_DUPLICATE_CONTACT = "This contact already exists.";

private static final Logger logger = LogsCenter.getLogger(EditCommand.class);

private final Index index;
private final EditPersonDescriptor editPersonDescriptor;

Expand Down Expand Up @@ -87,6 +91,7 @@ public String execute(Model model) throws CommandException {
Person editedPerson = createEditedPerson(personToEdit, editPersonDescriptor);

if (!personToEdit.isSamePerson(editedPerson) && model.hasPerson(editedPerson)) {
logger.finer("Recognized as duplicate person: " + editedPerson);
throw new CommandException(MESSAGE_DUPLICATE_CONTACT);
}

Expand Down

0 comments on commit 9e2e174

Please sign in to comment.