Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developer Guide Appendix #272

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Update Developer Guide Appendix #272

merged 8 commits into from
Apr 15, 2024

Conversation

darkvoid32
Copy link

Closes #271.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (ca79bd1) to head (e7aab24).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #272   +/-   ##
=========================================
  Coverage     77.02%   77.02%           
  Complexity      513      513           
=========================================
  Files            74       74           
  Lines          1589     1589           
  Branches        143      143           
=========================================
  Hits           1224     1224           
  Misses          335      335           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony added this to the v1.4 milestone Apr 13, 2024
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some nits to check.

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yisiox yisiox merged commit 271482d into master Apr 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve DG appendix
3 participants