Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage component: serialization and deserialization #7

Merged
merged 16 commits into from
Feb 27, 2024

Conversation

aureliony
Copy link

No description provided.

@aureliony aureliony changed the title Refactor serialization to json Refactor serialization and deserialization Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.16%. Comparing base (af490e0) to head (e2e21bf).

❗ Current head e2e21bf differs from pull request most recent head 10d3015. Consider uploading reports for the commit 10d3015 to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/ui/PersonCard.java 0.00% 4 Missing ⚠️
.../main/java/seedu/address/model/person/Address.java 75.00% 1 Missing ⚠️
...rc/main/java/seedu/address/model/person/Email.java 75.00% 1 Missing ⚠️
src/main/java/seedu/address/model/person/Name.java 75.00% 1 Missing ⚠️
...c/main/java/seedu/address/model/person/Person.java 90.90% 0 Missing and 1 partial ⚠️
...rc/main/java/seedu/address/model/person/Phone.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
- Coverage     75.26%   74.16%   -1.10%     
+ Complexity      419      404      -15     
============================================
  Files            71       69       -2     
  Lines          1338     1285      -53     
  Branches        126      116      -10     
============================================
- Hits           1007      953      -54     
  Misses          301      301              
- Partials         30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony assigned aureliony and unassigned aureliony Feb 26, 2024
@darkvoid32 darkvoid32 merged commit dfb1e3d into AY2324S2-CS2103T-W12-3:master Feb 27, 2024
3 checks passed
@aureliony aureliony added this to the v1.2 milestone Mar 1, 2024
@aureliony aureliony deleted the refactor branch March 1, 2024 12:57
@aureliony aureliony changed the title Refactor serialization and deserialization Refactor storage component: serialization and deserialization Mar 1, 2024
@aureliony aureliony linked an issue Mar 1, 2024 that may be closed by this pull request
@aureliony aureliony restored the refactor branch March 2, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the existing codebase: storage and model components
2 participants