Skip to content

update ppp #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinneo merged 1 commit into from
Apr 8, 2025
Merged

update ppp #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/team/Ahmish15.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ BMI Sequence Diagram and Storage Class Diagram. I also talked about the BMI comm

## Contributions to team-based tasks
revamped our add commands by splitting them into their logic and parsing respectively. This made it easier to read and understand. I also actively participated in discussing how we should design other functions in the TP and also gave key inputs on how to structure the entire project to make it more OOP. Incorporated the Time parser into the add commands, and also implemented limits and checks to the various inputs in the TP to make sure all inputs make sense and inputs that do not make sense are caught by exceptions. I also did the test cases for BMI command, List Command and Search Command. After the Mock Pe I helped with fixing many of the bugs that were raised.
Did many of the debugs after Mock PE, such as setting limits to inputs, editing DateParser so that inputs are valid and assisting my groupmate, Jason to enhance our TP, such that if users were to edit our text file, exceptions would be thrown if got invalid inputs.

## Review/mentoring contributions
- https://github.com/AY2425S2-CS2113-W13-4/tp/pull/240
- https://github.com/AY2425S2-CS2113-W13-4/tp/pull/233
- https://github.com/AY2425S2-CS2113-W13-4/tp/pull/225
- https://github.com/AY2425S2-CS2113-W13-4/tp/pull/224
- https://github.com/AY2425S2-CS2113-W13-4/tp/pull/222
Expand Down