Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulthy translation key for covers #173

Open
DigiLive opened this issue Feb 8, 2025 · 2 comments
Open

Faulthy translation key for covers #173

DigiLive opened this issue Feb 8, 2025 · 2 comments
Labels
bug Something isn't working valid The problem or suggestion is confirmed and should be taken care of

Comments

@DigiLive
Copy link
Collaborator

DigiLive commented Feb 8, 2025

I think "covers":{"all_covers":"All Covers","covers":"Covers"} and "covers":{"all_covers":"Alle Bedekkingen","covers":"Bedekkingen"}
should be "cover":{"all_covers":"All Covers","covers":"Covers"}and "cover":{"all_covers":"Alle Bedekkingen","covers":"Bedekkingen"}

covers -> cover like in "climate":{"all_climates":"All Climates","climates":"Climates"}

The localization call expects the key to be singular: title:n.H.customLocalize("cover.all_covers")

If I change these two keys, the bug disappears for me.

Originally posted by @devmarcstorm in #157 (comment)

@devmarcstorm
Copy link
Contributor

@DigiLive If you'd like, I can create a pull request with the fixes for translations/en.json and translations/nl.json.

@DigiLive DigiLive added bug Something isn't working valid The problem or suggestion is confirmed and should be taken care of labels Feb 9, 2025
@devmarcstorm
Copy link
Contributor

@DigiLive I forgot to set “Closes #173” in the pull request. Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working valid The problem or suggestion is confirmed and should be taken care of
Projects
None yet
Development

No branches or pull requests

2 participants