Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faulty translation key for covers #174

Merged

Conversation

devmarcstorm
Copy link
Contributor

Description

I fixed the translation keys for covers from covers to cover in both currently supported languages (translations/en.json, translations/nl.json). See Issue #173.

Type of Change

Put an x in all boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Hot fix (corrects a major software bug or fault and should released as quickly as possible.)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Testing

I compiled the project, including the changes, via npx webpack --mode=production and tested the compiled mushroom-strategy.js on my Home Assistant instance. I confirmed that the cover strings are now properly displayed in the domain and area views.

Impact

I only changed the keys in the translation files, so the changes should not have any impact on the project outside of fixing the displayed strings.

Additional Information

Before
before - the cover title is "cover.all_covers" and the subtitle includes "cover.covers"

After
after - the cover title is "All Covers" and the subtitle includes "Covers"

Checklist

Put an x in all boxes that apply

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@DigiLive DigiLive merged commit 7f4a6bc into AalianKhan:main Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants