Add device subviews #155
Open
Add device subviews #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for device subviews. User can add subviews for selected devices by specifying them in configuration. For such devices only specified entity cards are displayed in Area subview, other cards are accessible on newly added device subview. Motivation: - avoiding clutter on area subviews - hiding rarely used functionalities (z-wave pings, obscure options, power meters)
AalianKhan
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Thanks a lot for your contribution! It really improves the readability of the overall Dashboard.
To keep the auto theme going. Should devices with more than 4 or so entities be automatically turned into devices with subview? and have an option if the user wants it to be seperate? What do you think @DigiLive?
| @@ -70,6 +72,26 @@ class MushroomStrategy extends HTMLTemplateElement { | |||
| } | |||
| } | |||
|
|
|||
| // Create subviews for each device with config in devices section. | |||
| const devicesWithSubviews = Helper.strategyOptions.devices ?? {}; | |||
There was a problem hiding this comment.
Card Options allows you to list device ids for card configuration. Instead of creating a new option, it is better to extend CustomCardConfig and add the deviceSubView option to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for device subviews. User can add subviews for selected devices by specifying them in configuration. For such devices only specified entity cards are displayed in Area subview, other cards are accessible on newly added device subview.
Motivation: