Number range filter#2478
Conversation
Co-authored-by: christophscheuing <christophscheuing@users.noreply.github.com>
|
Deployed to https://pr-2478.aam-digital.net/ |
|
Remaining problem: The two input fields in the RangeInputComponent don't accept manually entering negative and decimal numbers. Not sure why this is. Probably has to do with the Not sure either why test for RangeInputComponent fails. |
sleidig
force-pushed
the
number_range_filter
branch
from
2b0f66d to
972ab4c
Compare
sleidig
left a comment
sleidig
left a comment
There was a problem hiding this comment.
Nice, clear code and good functionality! 😊
Just a few minor things that I commented or asked.
Functionality seems to work very well and smoothly
|
|
||
| ngAfterViewInit() { | ||
| if (this.activateValidation) { | ||
| this.formControlDirective.form.addValidators([this.validatorFunction]); |
There was a problem hiding this comment.
we could add a unit test for this
| this.formControl.value.to?.toString() ?? "", | ||
| ]; | ||
|
|
||
| this.filterConfig.selectedOptionChange.emit( |
There was a problem hiding this comment.
we could add a unit test to ensure a formControl change correctly updates the filterConfig (and emits selectedOptionChange)
…mponent.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…input/range-input.component.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
2 participants
Relates to #2310 .
Still WIP.