Number range filter #2478
Draft
Number range filter #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: christophscheuing <[email protected]>
Co-authored-by: Sebastian <[email protected]>
|
Deployed to https://pr-2478.aam-digital.net/ |
|
Remaining problem: The two input fields in the RangeInputComponent don't accept manually entering negative and decimal numbers. Not sure why this is. Probably has to do with the Not sure either why test for RangeInputComponent fails. |
sleidig
force-pushed
the
number_range_filter
branch
from
2b0f66d
to
972ab4c
Compare
sleidig
reviewed
Oct 25, 2024
src/app/core/basic-datatypes/number/edit-number/edit-number.component.html
Outdated
Show resolved
Hide resolved
src/app/core/filter/filter-generator/filter-generator.service.ts
Outdated
Show resolved
Hide resolved
src/app/core/basic-datatypes/number/number-range-filter/number-range-filter.component.scss
Show resolved
Hide resolved
src/app/core/basic-datatypes/number/number-range-filter/range-input/range-input.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/basic-datatypes/number/number-range-filter/range-input/range-input.component.ts
Outdated
Show resolved
Hide resolved
|
|
||
| ngAfterViewInit() { | ||
| if (this.activateValidation) { | ||
| this.formControlDirective.form.addValidators([this.validatorFunction]); |
There was a problem hiding this comment.
we could add a unit test for this
| this.formControl.value.to?.toString() ?? "", | ||
| ]; | ||
|
|
||
| this.filterConfig.selectedOptionChange.emit( |
There was a problem hiding this comment.
we could add a unit test to ensure a formControl change correctly updates the filterConfig (and emits selectedOptionChange)
…mponent.html Co-authored-by: Sebastian <[email protected]>
…input/range-input.component.ts Co-authored-by: Sebastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2310 .
Still WIP.