feat: add multi-query support #2644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomwwinter
commented
Oct 30, 2024
•
tomwwinter
commented
|
Deployed to https://pr-2644.aam-digital.net/ |
sleidig
reviewed
Oct 30, 2024
| * {groupTitle: "This is a group", items: [...]} | ||
| * | ||
| */ | ||
| @DatabaseField() reportDefinition: ReportDefinitionDto[]; |
There was a problem hiding this comment.
maybe better "reportDefinitions" as this is an array?
Comment on lines
+43
to
+44
| * (sql v2 only) transformations that are applied to input variables (e.g. startDate, endDate) | ||
| * example: {startDate: ["SQL_FROM_DATE"], endDate: ["SQL_TO_DATE"]} |
There was a problem hiding this comment.
Suggested change
| * (sql v2 only) transformations that are applied to input variables (e.g. startDate, endDate) | |
| * example: {startDate: ["SQL_FROM_DATE"], endDate: ["SQL_TO_DATE"]} | |
| * (sql v2 only) transformations that are applied to input variables (e.g. startDate, endDate) | |
| * the keys can be used as placeholders (`$key`; e.g. `WHERE c.date BETWEEN $startDate AND $endDate`) in SQL queries | |
| * example: {startDate: ["SQL_FROM_DATE"], endDate: ["SQL_TO_DATE"]} |
Is this the correct format or ${key}?
There was a problem hiding this comment.
It's just $key. e.g.
SELECT * FROM WHERE c.date BETWEEN $startDate AND $endDate
src/app/features/reporting/reporting/select-report/select-report.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/reporting/reporting/sql-v2-table/sql-v2-table.component.html
Outdated
Show resolved
Hide resolved
src/app/features/reporting/reporting/sql-v2-table/sql-v2-table.component.ts
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Nov 4, 2024
| try { | ||
| return this.sqlReportService.flattenData(value); | ||
| } catch (error) { | ||
| console.log(error); |
Comment on lines
+101
to
+154
| * [ | ||
| * [ | ||
| * { | ||
| * "Patenschaften neu verknüpft": 6 | ||
| * } | ||
| * ], | ||
| * [ | ||
| * { | ||
| * "Patenschaften Aktiv": 0 | ||
| * } | ||
| * ], | ||
| * [ | ||
| * { | ||
| * "Mentees neu aufgenommen": 2 | ||
| * } | ||
| * ], | ||
| * { | ||
| * "Mentoren erreicht": [ | ||
| * [ | ||
| * { | ||
| * "junge Erwachsene 20 bis 29 Jahren": 4 | ||
| * } | ||
| * ], | ||
| * [ | ||
| * { | ||
| * "Erwachsene 30 bis 49 Jahren": 4 | ||
| * } | ||
| * ] | ||
| * ] | ||
| * }, | ||
| * [ | ||
| * { | ||
| * "anzahl": 3, | ||
| * "status": "BEENDET", | ||
| * "foerderungDurch": null | ||
| * }, | ||
| * { | ||
| * "anzahl": 1, | ||
| * "status": "MATCHING_LÄUFT", | ||
| * "foerderungDurch": null | ||
| * }, | ||
| * { | ||
| * "anzahl": 1, | ||
| * "status": "MATCHING_LÄUFT", | ||
| * "foerderungDurch": "Menschen stärken Menschen" | ||
| * }, | ||
| * { | ||
| * "anzahl": 1, | ||
| * "status": "PATENSCHAFT", | ||
| * "foerderungDurch": null | ||
| * } | ||
| * ] | ||
| * ] | ||
| * |
There was a problem hiding this comment.
maybe we can define a slightly shorter and English example for the code docs here?
| * @param data raw ReportCalculationData or sub-array | ||
| * @param level each level will add some left-padding to visualize hierarchy | ||
| */ | ||
| flattenData(data: any[], level = 0): SqlReportRow[] { |
There was a problem hiding this comment.
strictly speaking we should add some unit tests for such methods ...
|
|
||
| let csv = ""; | ||
|
|
||
| csv += "Name" + ",".repeat(deepestLevel + 1) + "Value\n"; |
There was a problem hiding this comment.
any particular reason why we don't use PapaParse library for this?
Are we sure values are always escaped properly to not break CSV formating / delimiters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.