Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update dependencies #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elmarquez
Copy link

Update dependencies. Increment package version.

Copy link
Owner

@AaronCCWong AaronCCWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR! It appears that this change breaks the tests.

@@ -26,7 +26,7 @@ module.exports = {
]
},
devServer: {
contentBase: path.join(__dirname, './e2e')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change?

@@ -28,7 +28,7 @@ module.exports = {
],
},
devServer: {
contentBase: path.resolve(__dirname, '.'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the purpose for this change? It appears that this change breaks npm run start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants