Skip to content

Commit

Permalink
add support for Ruby 3.4
Browse files Browse the repository at this point in the history
  • Loading branch information
AaronLasseigne committed Feb 2, 2025
1 parent 5787f9b commit e735d96
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
ruby-version: "3.4"
bundler-cache: true

- name: Lint
Expand All @@ -23,7 +23,7 @@ jobs:
name: Test Ruby ${{ matrix.ruby }} on ActiveModel ${{ matrix.activemodel }}
strategy:
matrix:
ruby: ["3.2", "3.3"]
ruby: ["3.4"]
activemodel: ["8.0"]
include:
- activemodel: "7.2"
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# [5.5.0][] (TBD)

## Added

- Support for Ruby 3.4.

# [5.4.0][] (2024-11-23)

## Added
Expand Down
6 changes: 5 additions & 1 deletion spec/active_interaction/base_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ def execute
# NOTE: the relative position between this method
# and the compose line should be preserved.
def self.composition_location
"#{__FILE__}:#{__LINE__ + 4}:in `execute'"
if RUBY_VERSION >= '3.4'
"#{__FILE__}:#{__LINE__ + 7}:in 'InterruptInteraction#execute'"
else
"#{__FILE__}:#{__LINE__ + 5}:in `execute'"
end
end

def execute
Expand Down

0 comments on commit e735d96

Please sign in to comment.