Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight selected row #140

Closed
wants to merge 2 commits into from
Closed

Conversation

fen89
Copy link

@fen89 fen89 commented Feb 24, 2025

Description

Currently there is no indicator of the current selected row - would be nice to have that.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested directly via tauri dev - you can see Process Memory Compression as selected:

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fen89 fen89 requested a review from Abdenasser as a code owner February 24, 2025 08:01
@fen89 fen89 mentioned this pull request Feb 24, 2025
@Abdenasser
Copy link
Owner

I would say, why and what does it mean to select a process ?

@fen89
Copy link
Author

fen89 commented Feb 26, 2025

I would say, why and what does it mean to select a process ?

I am not sure if I understand correctly, but selecting a process , e.g. clicking on a row and highlight it uses the same code from the processes store like the details modal.

@Abdenasser
Copy link
Owner

I would say, why and what does it mean to select a process ?

I am not sure if I understand correctly, but selecting a process , e.g. clicking on a row and highlight it uses the same code from the processes store like the details modal.

@fen89 I mean why do you need to select a process ? what does it add as value? and how it compares with pinning a process?

@Abdenasser Abdenasser closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants