chore(deps): bump the frontend-runtime-major group across 1 directory with 4 updates - #427
Conversation
PR Context Summary
Suggested issue links
Use |
|
Not merging as-is — this is a Tailwind 3 -> 4 major and needs a real migration, not a version bump. frontend-check fails on a PostCSS error because v4 moves the plugin to I would rather split these: the low-risk ones can go on their own, and Tailwind v4 gets a dedicated PR where we can actually review the config migration and diff the rendered UI. Grouping four majors together means one bad one blocks all of them. |
a651a92 to
e0d9ec9
Compare
… with 4 updates Bumps the frontend-runtime-major group with 4 updates in the /frontend directory: [react-dropzone](https://github.com/react-dropzone/react-dropzone), [@testing-library/jest-dom](https://github.com/testing-library/jest-dom), [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) and [typescript](https://github.com/microsoft/TypeScript). Updates `react-dropzone` from 14.3.8 to 19.1.1 - [Release notes](https://github.com/react-dropzone/react-dropzone/releases) - [Commits](react-dropzone/react-dropzone@v14.3.8...v19.1.1) Updates `@testing-library/jest-dom` from 6.9.1 to 7.0.0 - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.9.1...v7.0.0) Updates `tailwindcss` from 3.4.18 to 4.3.3 - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.3.3/packages/tailwindcss) Updates `typescript` from 5.9.3 to 7.0.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](https://github.com/microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-version: 7.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: frontend-runtime-major - dependency-name: react-dropzone dependency-version: 19.1.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: frontend-runtime-major - dependency-name: tailwindcss dependency-version: 4.3.3 dependency-type: direct:development update-type: version-update:semver-major dependency-group: frontend-runtime-major - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major dependency-group: frontend-runtime-major ... Signed-off-by: dependabot[bot] <support@github.com>
e0d9ec9 to
10a216c
Compare
…ump builds The grouped bump landed four majors at once and frontend-check failed on a PostCSS error. Each one needed a real change, not just a version number. Tailwind 3 -> 4: - postcss.config.js now loads @tailwindcss/postcss; v4 prefixes internally, so autoprefixer leaves the chain. - globals.css swaps the three @tailwind directives for @import "tailwindcss". @config keeps tailwind.config.js authoritative, so the design tokens and theme extensions stay where they are — no CSS-first @theme rewrite. - tailwindcss-animate is v3-only; tw-animate-css replaces it with the same utility names. Nothing in src/ actually uses them today, so this is purely keeping parity. TypeScript 5.9 -> 7: TS 7 is the native rewrite and no longer exposes the JS compiler API Next.js links against, so `next build` cannot load it. Enable experimental.useTypeScriptCli, Next's documented path for TS 7, which routes type-checking through the tsc CLI. Type errors still fail the build. react-dropzone 14 -> 19 and @testing-library/jest-dom 6 -> 7 needed no source changes; the useDropzone options in upload/page.tsx are unchanged in 19. Verified: biome check clean, 300 unit tests pass, production build succeeds across all 21 routes, 14 Playwright e2e pass. One deliberate visual change. Tailwind v3 silently emitted nothing for opacity modifiers on arbitrary var() colours, so 18 selectors like bg-[color:var(--void)]/92 were dead classes. v4 resolves them via color-mix(), so they now render. Diffing v3 and v4 builds of the same routes: ~6% of pixels move, max channel delta 39/765 — the app header and a few panel backdrops pick up the tint the markup always asked for. Subtle, and arguably a fix, but it is a real change to how the shell looks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QxroatoR4x1pREFT7ggnS7
ApprovabilityVerdict: Needs human review Unable to check for correctness in a2c8b6b. Major version bumps (TypeScript 5→7, Tailwind 3→4, react-dropzone 14→19) with breaking API changes that required configuration rewrites. The designated code owner should verify build and runtime behavior after these significant dependency upgrades. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
|
Pushed a migration commit — all four majors needed real changes, and frontend-check is green now (biome clean, 300 unit tests, build across all 21 routes, 14 Playwright e2e). What it took: Two things worth a second opinion before this merges. TypeScript 7 is the native rewrite and no longer exposes the JS compiler API Next links against, so |
Abhash-Chakraborty
left a comment
There was a problem hiding this comment.
Migration verified end to end: biome clean, 300 unit tests, production build across all 21 routes, 14 Playwright e2e including the dark-mode contrast checks. Compared the v3 and v4 CSS class inventories too — 2174 vs 2203 selectors, nothing lost (the only v3-only entry was the unused container utility; this app uses its own container-shell). Accepting the header/backdrop tint change as the fix it is, and the experimental TS-CLI flag as the documented path for TS 7.
…ontend-runtime-major-5c7010b99a
Abhash-Chakraborty
left a comment
There was a problem hiding this comment.
Migration verified end to end: biome clean, 300 unit tests, production build across all 21 routes, 14 Playwright e2e including the dark-mode contrast checks. Compared the v3 and v4 CSS class inventories too — 2174 vs 2203 selectors, nothing lost (the only v3-only entry was the unused container utility; this app uses its own container-shell). Accepting the header/backdrop tint change as the fix it is, and the experimental TS-CLI flag as the documented path for TS 7.
Bumps the frontend-runtime-major group with 4 updates in the /frontend directory: react-dropzone, @testing-library/jest-dom, tailwindcss and typescript.
Updates
react-dropzonefrom 14.3.8 to 19.1.1Release notes
Sourced from react-dropzone's releases.
... (truncated)
Commits
4599a84fix: ignore drops on the dropzone while the file dialog is open (closes #1455)ec2af85feat: support async validatorc678d38fix: detect dragged files via items kind when types omit Files (#1409)fcded10docs: warn that a button root needs type=button inside a form (closes #1292)36e92bddocs: note Android photo-picker hides camera (closes #1417)d1d290cfix: hide file input in-flow to prevent scroll jump (fixes #1413)696d47cfix!: accept files up to the limit instead of rejecting the batch03f0f6efeat: add isDragUnknown state and skip validator during drag (closes #1408, c...2b8dcfbfix: prevent browser opening files dropped on disabled/noDrag dropzone (fixes...5d14000docs: add file dialog caveats for <label> root and open() timingMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react-dropzone since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Updates
@testing-library/jest-domfrom 6.9.1 to 7.0.0Release notes
Sourced from @testing-library/jest-dom's releases.
Commits
1e39089feat: add toContainAnyBy* and toContainOneBy* query matcherscae44dffeat: add toContainAnyBy* and toContainOneBy* query matchers (#731)55c07ceci: switch release to npm trusted publishing (#726)213256fdocs: move toHaveSelection from the deprecated section (#717)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@testing-library/jest-domsince your current version.Updates
tailwindcssfrom 3.4.18 to 4.3.3Release notes
Sourced from tailwindcss's releases.
... (truncated)
Changelog
Sourced from tailwindcss's changelog.
... (truncated)
Commits
c2b24dd4.3.3 (#20334)e48c5e8Fix weird character rendering on Windows with Japanese locale (#20318)35a3e9cAlways produce\<length>value when optimizing--spacing(0)(#20319)4af47fbFix hues in achromatic theme colors to benone(#20314)5835691Handle CSS nesting natively (#20124)67c745eFix bug in attribute selector parsing (#20303)2683903Support fractional opacity modifiers for named shadow sizes (#20302)04588b1Fix theme() in JS plugins returning unresolved object instead of DEFAULT valu...b53fa09fix: exclude iframes from focus-visible auto outline in Preflight (#20292)ef79119Bump dependencies (#20300)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for tailwindcss since your current version.
Updates
typescriptfrom 5.9.3 to 7.0.2Release notes
Sourced from typescript's releases.
Commits
Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.