Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Home Icon to every Page #148

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Adding Home Icon to every Page #148

merged 8 commits into from
Jul 11, 2024

Conversation

Ojas-Arora
Copy link
Contributor

@Ojas-Arora Ojas-Arora commented Jul 9, 2024

Description

@Abidsyed25 I have added the home icon to every page and also improved the styling in some pages. Kindly review this.

Fixes: #147

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Copy link

vercel bot commented Jul 9, 2024

@Ojas-Arora is attempting to deploy a commit to the abidsyed25's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quine-scrap-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 1:12pm

@Abidsyed25
Copy link
Owner

@Ojas-Arora few checks have been failed. Please try to resolve that and also resolve merge conflicts

@Abidsyed25
Copy link
Owner

@Ojas-Arora try to add a video of what changes you exactly made on this website

@Ojas-Arora
Copy link
Contributor Author

@Abidsyed25 ok

@Ojas-Arora
Copy link
Contributor Author

@Abidsyed25 I have resolved all the conflicts and I don't know how to make video but I can tell u what changes I have made
Added Home Icon png in all the pages i.e about us,FAQ,Terms and Conditions and Contact Page.
Linked the home icon in all the pages i.e about us,FAQ,Terms and Conditions and Contact Page.
Improved the styling in these pages also.
Kindly review this.

@Abidsyed25 Abidsyed25 merged commit 9a0f675 into Abidsyed25:main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[FEATURE]: Adding Home icon
4 participants