Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed footer component #61

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Conversation

gdhyani
Copy link
Contributor

@gdhyani gdhyani commented Jun 4, 2024

Description

Footer component with copywrite and year

Fixes: #59

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

vercel bot commented Jun 4, 2024

@gdhyani is attempting to deploy a commit to the abidsyed25's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quine-scrap-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 6:16am

@Abidsyed25
Copy link
Owner

@gdhyani its not visible. Try to change background color

@gdhyani
Copy link
Contributor Author

gdhyani commented Jun 6, 2024

What colour do you want.
I choose to keep it simple as it only contains copyright.

@gdhyani gdhyani closed this Jun 6, 2024
@gdhyani gdhyani force-pushed the footer-component branch from 6819f43 to 6f431da Compare June 6, 2024 14:18
@Abidsyed25
Copy link
Owner

@gdhyani Hey, you can also change text color instead of background-color. Because the text is invisible on the website.

@gdhyani
Copy link
Contributor Author

gdhyani commented Jun 7, 2024

sir you closed the request. I have changed opacity of footer for better text visibility.

@gdhyani
Copy link
Contributor Author

gdhyani commented Jun 7, 2024

Can i reopen and push the new code.

@Abidsyed25
Copy link
Owner

@gdhyani looks better now

@Abidsyed25 Abidsyed25 merged commit 62bf3b2 into Abidsyed25:main Jun 8, 2024
2 checks passed
@gdhyani gdhyani deleted the footer-component branch June 8, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[FEATURE]: Footer for the website
2 participants