Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove funds from IBC client SendFunds #494

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

CyberHoward
Copy link
Contributor

@CyberHoward CyberHoward commented Oct 11, 2024

This PR removes funds field from the IBC client SendFunds function. SendFunds now uses msg_info.funds instead.

Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1764831
Status:⚡️  Build in progress...

View logs

@Kayanski
Copy link
Contributor

Wait so the user can't sent funds that are located inside their account already ? Or in a complicated way only ?

@CyberHoward
Copy link
Contributor Author

Sorry, description wasn't very clear.

Instead of using the funds field specified within the message, this pr removes it to just use the msg_info.funds instead. That way we don't have to replicate that data.

Copy link
Contributor

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

framework/contracts/native/ibc-client/src/commands.rs Outdated Show resolved Hide resolved
@CyberHoward CyberHoward merged commit 8be7008 into develop/v2 Oct 14, 2024
9 of 12 checks passed
@CyberHoward CyberHoward deleted the robin/remove-funds-from-ibc-client-sendfunds branch October 14, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants