Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added migration function from xion accounts #533

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Conversation

Kayanski
Copy link
Contributor

This PR aims at modifying the account migration function to be able to migrate xion accounts to the Abstract Account

Checklist

  • CI is green.
  • Changelog updated.

Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d31895
Status:⚡️  Build in progress...

View logs

Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small details before we merge it

framework/contracts/account/Cargo.toml Outdated Show resolved Hide resolved
framework/contracts/account/src/migrate.rs Outdated Show resolved Hide resolved
framework/contracts/account/src/migrate.rs Show resolved Hide resolved
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 7.40741% with 75 lines in your changes missing coverage. Please review.

Project coverage is 74.2%. Comparing base (bf989a9) to head (f3df2fc).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
framework/contracts/account/src/migrate.rs 8.4% 65 Missing ⚠️
...work/packages/abstract-interface/src/deployment.rs 0.0% 10 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...work/packages/abstract-interface/src/deployment.rs 77.4% <0.0%> (-3.3%) ⬇️
framework/contracts/account/src/migrate.rs 10.8% <8.4%> (-89.2%) ⬇️

... and 36 files with indirect coverage changes

@Kayanski Kayanski merged commit 7413a12 into main Nov 12, 2024
5 of 9 checks passed
@Kayanski Kayanski deleted the migrate-xion-accounts branch November 12, 2024 10:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account documentation Improvements or additions to documentation interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants