Skip to content

Fix typos #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions framework/contracts/native/ibc-client/src/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ pub fn execute_register_infrastructure(
REVERSE_POLYTONE_NOTE.save(deps.storage, &note, &host_chain)?;

// When registering a new chain host, we need to get the remote proxy address of the local note.
// We do so by calling an empty message on the polytone note. This will come back in form of a execute by callback
// We do so by calling an empty message on the polytone note. This will come back in form of an execute by callback

let note_proxy_msg = wasm_execute(
note,
Expand Down Expand Up @@ -164,7 +164,7 @@ pub fn execute_send_packet(

let note_message = match &action {
HostAction::Dispatch { .. } | HostAction::Helpers(_) => {
// Verify that the sender is a account contract
// Verify that the sender is an account contract
let account = registry.assert_account(&info.sender, &deps.querier)?;

// get account_id
Expand Down Expand Up @@ -345,7 +345,7 @@ pub fn execute_register_account(

let registry = RegistryContract::new(deps.as_ref(), abstract_code_id)?;

// Verify that the sender is a account contract
// Verify that the sender is an account contract
let account = registry.assert_account(&info.sender, &deps.querier)?;

// get account_id
Expand Down Expand Up @@ -393,7 +393,7 @@ pub fn execute_send_funds(

let registry = RegistryContract::new(deps.as_ref(), abstract_code_id)?;
let ans = AnsHost::new(deps.as_ref(), abstract_code_id)?;
// Verify that the sender is a account contract
// Verify that the sender is an account contract

let account = registry.assert_account(&info.sender, &deps.querier)?;

Expand Down Expand Up @@ -443,7 +443,7 @@ pub(crate) fn execute_send_funds_with_actions(
let coin = cw_utils::one_coin(&info)?;

let ibc_infra = IBC_INFRA.load(deps.storage, &host_chain)?;
// Verify that the sender is a account contract
// Verify that the sender is an account contract
let abstract_code_id =
native_addrs::abstract_code_id(&deps.querier, env.contract.address.clone())?;
let registry = RegistryContract::new(deps.as_ref(), abstract_code_id)?;
Expand Down
4 changes: 2 additions & 2 deletions framework/docs/src/ibc/account-ibc.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Remember that this step is optional as accounts are created automatically when s

### Account ID structure

The remote Interchain Abstract Account will have the same account sequence but will have a different trace. Let's take an example. A account on `Neutron` with account sequence `42` wants to create accounts on `Osmosis` and `Stargaze`.
The remote Interchain Abstract Account will have the same account sequence but will have a different trace. Let's take an example. An account on `Neutron` with account sequence `42` wants to create accounts on `Osmosis` and `Stargaze`.

- Their account ID on `Neutron` is `local-42`.
- Their account ID on `Osmosis` is `neutron-42`.
Expand Down Expand Up @@ -181,7 +181,7 @@ Interchain Abstract Accounts are traditional Abstract Accounts controlled by the

When an action is triggered by a remote account, the `ibc-host` does the following verifications:

- If an local account already exists on-chain for the remote account, it just dispatches the message to the account.
- If a local account already exists on-chain for the remote account, it just dispatches the message to the account.
- If no account exists, it creates one with default metadata and THEN dispatches the messages to this new account.

The Account creation process is therefore not mandatory when interacting with Interchain Abstract Accounts. This is why when you create an Abstract Account, you automatically have an account on every connected chains!
Expand Down
2 changes: 1 addition & 1 deletion framework/packages/abstract-sdk/src/base/contract_base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ pub type IbcCallbackHandlerFn<Module, Error> =
// ANCHOR_END: ibc

// ANCHOR: module_ibc
/// Function signature for an Module to Module IBC handler.
/// Function signature for a Module to Module IBC handler.
pub type ModuleIbcHandlerFn<Module, Error> =
fn(DepsMut, Env, Module, ModuleIbcInfo, Binary) -> Result<Response, Error>;
// ANCHOR_END: module_ibc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ pub enum ExecuteMsg {
},
/// Only callable by Account
/// Register an Account on a remote chain over IBC
/// This action creates a account for them on the remote chain.
/// This action creates an account for them on the remote chain.
Register {
/// host chain to be executed on
/// Example: "osmosis"
Expand Down