Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure CI to use reusable workflow #455

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

cary-ilm
Copy link
Member

This follows the pattern adopted by OpenEXR see
AcademySoftwareFoundation/openexr#1921 for details.

  • Introduce the process of validating the installed files by comparing the install_manifest.txt files to archived versions, one per build.

  • Factor out the jobs for the outdated VFX reference platform years, which require workarounds for the outdated glibc.

  • Add a build that validates custom namespaces. This also fixes several problems with building the python bindings when the library has been built with a custom namespace. The code had "Imath::" where it should have had "IMATH_NAMESPACE::".

This follows the pattern adopted by OpenEXR see
AcademySoftwareFoundation/openexr#1921
for details.

* Introduce the process of validating the installed files by
  comparing the install_manifest.txt files to archived versions, one per
  build.

* Factor out the jobs for the outdated VFX reference platform
  years, which require workarounds for the outdated glibc.

* Add a build that validates custom namespaces. This also fixes
  several problems with building the python bindings when the library
  has been built with a custom namespace. The code had "Imath::" where
  it should have had "IMATH_NAMESPACE::".

Signed-off-by: Cary Phillips <[email protected]>
Copy link
Contributor

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a lot here, but it all seems consistently applied.

@cary-ilm cary-ilm merged commit d3be2c6 into AcademySoftwareFoundation:main Dec 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants