-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a combined version define in MaterialX C++ #2031
Add a combined version define in MaterialX C++ #2031
Conversation
Signed-off-by: Rui Yang <[email protected]>
This looks very promising, @ruiyang2021, and I think the unit test makes a good addition (though we may want to refine exactly where it's added). To resolve the EasyCLA error message above, feel free to follow the two links they provide in the message, and let us know how things go! |
Gotcha, thank you! Going to sort the CLA with my manager. By the way, I'll be on holiday for 3 weeks starting from next Monday. Can come back to this one in 3 weeks if I have to leave something unfinished today |
Hi @jstone-lucasfilm, I just passed the CLA check :) |
Excellent, thanks @ruiyang2021! For the location of the new test, I would actually recommend |
Signed-off-by: Rui Yang <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @ruiyang2021!
1734e6d
into
AcademySoftwareFoundation:main
Appreciate the help! |
PR for #1609
Also added a simple test in source/MaterialXTest/MaterialXCore/Library.cpp. Let me know if that's unnecessary