Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New email template #1382

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DiegoTavares
Copy link
Collaborator

@DiegoTavares DiegoTavares commented Jun 17, 2024

Rework the email template and remove imageworks email domains from EmailSupport. Company domains and CC emails can now be configured on opencue.properties.

Copy link

linux-foundation-easycla bot commented Jun 17, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@DiegoTavares DiegoTavares changed the title New email template WIP: New email template Jun 17, 2024
@DiegoTavares
Copy link
Collaborator Author

I'm waiting for Samer (@Samer_sef - https://github.com/Samer-sef) to sign the CLA to be able to merge this in

@n-jay
Copy link
Contributor

n-jay commented Jun 19, 2024

PR effectively addresses issue #1322.

@DiegoTavares
Copy link
Collaborator Author

Here's a preview of how emails will look like after this change.

image

@DiegoTavares DiegoTavares changed the title WIP: New email template New email template Jun 19, 2024
Copy link
Collaborator

@ramonfigueiredo ramonfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoTavares

Approved. Thanks!

File file = null;
if (shouldCreateFile) {
try {
logger.info("\n\n\n\nhouldCreateFile \n\n\n\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove logger.info()

houldCreateFile -> You mean ShouldCreateFile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants