-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rqd] Python tests for rqd only v2 #1548
base: master
Are you sure you want to change the base?
[rqd] Python tests for rqd only v2 #1548
Conversation
This is due to setup.py test being is newer releases of python
… with split up requirements
Sorry, I've accidentally marked this PR as ready. |
I like where this PR is going. There's one thing I've been wanting to change on the project for a long time related to how we declare dependencies on requirements.txt and the whole setup.py weirdness. Python now support project configuration using a toml file which seems to be easier to maintain and more readable. I'm not proposing this should be tackled on this PR, but since it proposes a new directory for requirements, maybe it is a good time to investigate what it would take to convert the setup.py to toml. There's a good guideline here: |
Very interesting. Looks much better than the directory structure and I really like the optional part. But this PR was a good exercise into splitting it up. |
Looking at the unit tests for rqd, I get the sense they are not really being executed. It looks like both runLinux and runDarwin are failing but the ci job is still being marked as Success |
It turns out Here's my PR fixing some of the tests and replacing unittest with pytest (WIP) |
Link the Issue(s) this Pull Request is related to.
Is loosely related to #1441
Summarize your change.
Introduces small tests for RQD only on pull requests that tests "vanilla" python version from 3.7 to 3.11.
This is to make sure that rqd and basic pycue works with as many versions of python and not just the ones used by VFX platform and perhaps even prepare support for cutting edge python versions.
It also introduces the requirements directory to include more split up dependencies.
Edit :
This is based on PR #1547
Have not added python 3.13 since it doesn't support
2to3
anymore. Will need another solution for that (perhaps a simplesed
command?)