Fix rotation metadata loading incorrectly with FFMPEG 6 #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chxmberland
requested review from
bernie-laberge,
rogernelson and
geffrak
as code owners
chxmberland
force-pushed
the
fix/rotation-metadata-not-loaded-correctly_SG-35549
branch
from
e9281f4
to
6d15bbe
Compare
chxmberland
force-pushed
the
fix/rotation-metadata-not-loaded-correctly_SG-35549
branch
from
4d9ba50
to
bc7dffc
Compare
Signed-off-by: Ben Chamberland <[email protected]>
Signed-off-by: Ben Chamberland <[email protected]>
Signed-off-by: Ben Chamberland <[email protected]>
…agged Signed-off-by: Ben Chamberland <[email protected]>
chxmberland
force-pushed
the
fix/rotation-metadata-not-loaded-correctly_SG-35549
branch
from
0a975f1
to
ff8ae7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues #496
Summarize your change.
Added an additional check to another metadata field when loading movie clips to ensure that rotation metadata is captured correctly.
Describe the reason for the change.
In FFmpeg 6.0, rotation metadata can be loaded incorrectly without this check.
Describe what you have tested and on which operating system.
macOS Sonoma 14.5
Add a list of changes, and note any that might need special attention during the review.
side_datafield when movies are loaded in to RVIf possible, provide screenshots.