onion skin management in annotate tool #498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamouth13
requested review from
bernie-laberge,
rogernelson and
geffrak
as code owners
Signed-off-by: mamouth13 <[email protected]>
|
Bonjour @mamouth13 , Thank you for this excellent contribution to the Open RV effort ! |
|
Hi Bernard
You are welcome 😉
TL
Le mar. 16 juil. 2024, 15:38, Bernard Laberge ***@***.***> a
écrit :
… Bonjour @mamouth13 <https://github.com/mamouth13> ,
We apologize for the delay in reviewing your pull requests due to the fact
that some key reviewers were on vacation.
Thank you for this excellent contribution to the Open RV effort !
—
Reply to this email directly, view it on GitHub
<#498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDAOIQ6AHYFARN4LYN4M6ATZMUO6HAVCNFSM6AAAAABJ2F4J72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQHEYTQOJUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnionSkin management in annotation
Modifications
Added 5 properties into the
PaintIPNodenode:onionShow: enabled/disabled the drawing of onionSkin (default is false).onionBeforeFrame: the number of frames BEFORE a stroke on which the onionSkins will be drawn (default is 5).onionAfterFrame: the number of frames AFTER a stroke on which the onionSkins will be drawn (default is 5).onionBeforeColor: the color used to draw onionSkin BEFORE (default is red).onionAfterColor: the color used to draw onionSkin AFTER (default is green).Paint::PolyLineandPaint::Textnow manage those new properties and draw onionSkin on previous / next frames with the appropriate fading out colors.Modified the annotate rv-package:
drawpane.uito add the appropriate Ui to manage the above new properties.annotate_mode.muto properly handle the colorChooser with those new Ui.Tests
This has been tested on CentOS Linux 7.
Screenshot