Feature/Qt6 - Fixing the audio settings #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédrik Fuoco <[email protected]>
Signed-off-by: Cédrik Fuoco <[email protected]>
Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
force-pushed
the
qt6-audio-issues
branch
from
0682bda to
145c29d
Compare
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
merged commit 4b52c7e
into
AcademySoftwareFoundation:feature/qt6
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Qt6 - Fixing the audio settings
Linked issues
n/a
Describe the reason for the change.
The code that was handling the audio sample rate changes was refactored in this PR because of the Qt Audio module refactor in Qt 6. In Qt 5, you could get a list of valid sample rate from the audio device, but in Qt 6, you only get a minimum and maximum value.
With Qt6 OpenRV, the widget to change the sample rate is a SpinBox instead of a ComboBox.
What is left to do for Audio:
Describe what you have tested and on which operating system.
Windows, MacOS and Rocky.
If possible, provide screenshots.
With Qt 6, a QSpinBox is used for the sample rate setting.