(Enhancement) - Small changes to get OpenAPV working with OpenRV #843
Conversation
richardssam
requested review from
bernie-laberge,
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
We are calling "7.2" from the defines, but its actually doing a git checkout of the latest version. Most of the changes are needed for newer ffmpeg versions, so its possible the "7_2" will change to "8". I'm also disabling ffmpeg being built for OIIO, which seems unnecessary. The main goal was to be able to run OpenAPV in OpenRV, which has a very minor change to enable "slow" support, which is a bit of a mis-label, since its highly multi-threaded, it doesnt really need to multi-thread on frames, it just overstresses the codec. Signed-off-by: [email protected] <[email protected]>
We are doing this so we can get openapv that has just been released. It also includes a number of changes to the API that are in the latest release. Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
There was a problem hiding this comment.
New OpenAPV Support ! Great contribution !
Thank you @richardssam !
Note, openrv still has a ffmpeg dependancy but its a direct plugin, not via oiio. Signed-off-by: [email protected] <[email protected]>
|
I don't think its a good idea to blindly pull from the master branch, I'd highly recommend you pin it to a commit hash, especially if you want this to run this in CI. FFMpeg 8 is going to be release soon and should have OpenAPV support |
It looks like it modified some of the HTJ2K code too. Signed-off-by: [email protected] <[email protected]>
|
Thats a good point, perhaps we should wait, and bind it to that, I wasnt aware that it was so close to release. |
|
So the updated change is locked to the new 8.0 branch, which is not tagged as a release yet, but I think should be good. I have tested this on OSX, but not on windows or linux. |
|
Now updated with the official release, including the hash. |
|
should we add a cmake file to build the OpenAPV codec like we do with the DAV1D decoder? |
|
We dont actuallly need it, since we would be using the ffmpeg decoder, not the OpenAPV decoder, we just need ffmpeg-8. |
|
Interesting, I didn't know ffmpeg implemented thier own decoder. Have you compare performance to OpenAPV? |
|
From memory the ffmpeg one was faster. You do still need the OpenAPV
library for the encoding though. I'll try to track down the test results.
Sam.
…On Fri, 5 Sept 2025 at 16:30, Mark Reid ***@***.***> wrote:
*markreidvfx* left a comment (AcademySoftwareFoundation/OpenRV#843)
<#843 (comment)>
Interesting, I didn't know ffmpeg implemented thier own decoder. Have you
compare performance to OpenAPV?
—
Reply to this email directly, view it on GitHub
<#843 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2TR2GZCUQICZUOSUPCQ2D3RGUAPAVCNFSM6AAAAACCDPG2W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJYG44TCOJWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Support for "Master" ffmpeg branch, and OpenAPV support
OpenAPV is now commited to ffmpeg, but there hasnt yet been a new release. This allows you to set the built version of ffmpeg to be the master for ffmpeg.
It also updates a couple of minor API changes to ffmpeg that are in the newer release, along with some small changes to make OpenAPV work well.
Describe the reason for the change.
Getting OpenRV able to support OpenAPV now that its built into ffmpeg.
Describe what you have tested and on which operating system.
This has been tested on OSX and windows.
Add a list of changes, and note any that might need special attention during the review.
At least on OSX, I do also need the patch - #842 to make it compile, even though its not anything thats necessary for the newer ffmpeg version.