Add fallback to search for timecode in FFmpeg format context metadata #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g from the streams Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
cedrik-fuoco-adsk
changed the title
bernie-laberge
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
LGTM
(I think it would be nice to change the default fps to 24)
Thank you @cedrik-fuoco-adsk !
Signed-off-by: Cédrik Fuoco <[email protected]>
eloisebrosseau
approved these changes
Sep 15, 2025
cedrik-fuoco-adsk
merged commit 1cbff48
into
AcademySoftwareFoundation:main
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallback to search for timecode in FFmpeg context metadata
Linked issues
n/a
Summarize your change.
When the streams metadata do not have the timecode information, I added a fallback mechanism that looks at the format context metadata and try to find the
timecodeinformation.Describe the reason for the change.
During testing, there were some MXF media files that had the wrong start time.
Describe what you have tested and on which operating system.
MacOS
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.