SG-40198: Prep work for testing automation of concurrent annotations #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pid clash is unlikely) Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
Signed-off-by: Patrick Bergeron <[email protected]>
pbergeron-adsk
changed the title
pbergeron-adsk
requested review from
bernie-laberge,
eloisebrosseau and
cedrik-fuoco-adsk
as code owners
| } | ||
| } | ||
|
|
||
| method: color_hsv (void; Event event) |
There was a problem hiding this comment.
setColorHSV() ?
To conform with the rest of the file since it uses camel case for methods if I am not mistaken.
Signed-off-by: Patrick Bergeron <[email protected]>
bernie-laberge
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
This PR Addresses: SG-40198
Summarize your change.
This PR addresses 2 issues found in OpenRV to support Multiuser control of annotations.
First, when running/testing locally, the username is the same and the annotation ID is potentially the same, causing potential prop name conflicts. The prop name has the process id attached, to help differentiate such properties. There used to be a "computer" tag that went unused (a bug) which at the time aimed to do the same thing, but was never implemented properly.
Second, we now support events that draw on the viewport in NDC (normalized display coordinates) space. This allows annotation coords to be specified in a normalized [-1,1] space, which is much easier to use from a plugin (I'll spare the unfortunate details of trying to use absolute "pixel" or "event" coordinates). These functions aren't meant to be used for real live production purposes, they are there mainly for testing automation and scripting simultaneous strokes done in multiple RVs running locally on a single machine, because we don't have 8 hands and 4 mice ;)
Third, again for the purpose of drawing shapes automatically, we allow setting a color, eiher RGB or HSV. HSV is simpler to use because we can just change the hue and leave the color quite bright and visually distinctive.
Describe the reason for the change.
Automating the testing and bug fixing of concurrent strokes for live review.
Describe what you have tested and on which operating system.
Tested multiple clients on macos
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.
Not at this stage