Skip to content

Conversation

lithorus
Copy link
Contributor

@lithorus lithorus commented Sep 16, 2025

This pins the OTIO python module to a specific commit since the latest commit doesn't work with the compiled python interpreter.

Signed-off-by: Jimmy Christensen <[email protected]>
@lithorus
Copy link
Contributor Author

Looks like the Windows builds are randomly crashing for no good reason. Can you make it retry the single errored job?

@cedrik-fuoco-adsk
Copy link
Contributor

cedrik-fuoco-adsk commented Sep 16, 2025

The windows debug build is expected to fail, but a fix was commit today. You can "Update branch" and it will restart the CI @lithorus

I can do it if you do not see the "Update branch" button

@cedrik-fuoco-adsk
Copy link
Contributor

@lithorus Thanks for the contribution! But we can not pin to 0.17 because some newer commits are mandatory for the Live Review plugin.

Do you know which commit introduce the issue you are talking about?

The best we can do is to pin to the the commit that we need from the main branch for Live review plugin.

@lithorus
Copy link
Contributor Author

@lithorus Thanks for the contribution! But we can not pin to 0.17 because some newer commits are mandatory for the Live Review plugin.

Do you know which commit introduce the issue you are talking about?

The best we can do is to pin to the the commit that we need from the main branch for Live review plugin.

No, the only reason I discovered it was because I was re-building 2 internal version that both had the issue.

Can do some testing, but the weird thing is that it seems the OTIO has their own testing pipeline that hasn't picked up the error. Could be something to do with how OpenRV is building Python.

@lithorus
Copy link
Contributor Author

Alternatively requirements.tx would just use pypi instead of git directly. (without the pinning)

@lithorus lithorus changed the title Pin OpenTimelineIO to 0.17.0 in python build Pin OpenTimelineIO to specific commit in python build Sep 16, 2025
@lithorus
Copy link
Contributor Author

lithorus commented Sep 16, 2025

@cedrik-fuoco-adsk I found out that it was the absolute latest commit that breaks it.
AcademySoftwareFoundation/OpenTimelineIO@7f1ee9c

The one before doesn't have the issue and I have pinned it to that instead.

Also, I should mention that if I use my system python and install the otio module from latest master it works fine. It only breaks with the custom python build.

Copy link
Contributor

@bernie-laberge bernie-laberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks you @lithorus !

@lithorus
Copy link
Contributor Author

Has anyone else been able to reproduce the import error?
Just wondering if it's a fault on my setup (using ubuntu 24.04)

@bernie-laberge
Copy link
Contributor

Yes we're having the exact same issue now in our internal CICD on Windows.
What we don't understand is that the OpenRV's github actions Windows build does seem to work so we are wondering if this could be fixed by using a more recent CMake (we have a build currently in progress to validate this hypothesis). If the CMake update is not successful when we'll go with your PR. Thanks !

@lithorus
Copy link
Contributor Author

FYI, I also tested with a newer version of nanobind (since it seemed related to pybind11) which didn't help either.

@bernie-laberge
Copy link
Contributor

Updating CMake to version 3.31.6 did not work either. So we are merging your PR @lithorus.
Thank you for your help !

@bernie-laberge bernie-laberge merged commit f956acf into AcademySoftwareFoundation:main Sep 17, 2025
20 checks passed
@lithorus lithorus deleted the pin-otio-module branch September 19, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants