-
Notifications
You must be signed in to change notification settings - Fork 191
Pin OpenTimelineIO to specific commit in python build #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin OpenTimelineIO to specific commit in python build #910
Conversation
Signed-off-by: Jimmy Christensen <[email protected]>
Looks like the Windows builds are randomly crashing for no good reason. Can you make it retry the single errored job? |
The windows debug build is expected to fail, but a fix was commit today. You can "Update branch" and it will restart the CI @lithorus I can do it if you do not see the "Update branch" button |
@lithorus Thanks for the contribution! But we can not pin to 0.17 because some newer commits are mandatory for the Live Review plugin. Do you know which commit introduce the issue you are talking about? The best we can do is to pin to the the commit that we need from the main branch for Live review plugin. |
No, the only reason I discovered it was because I was re-building 2 internal version that both had the issue. Can do some testing, but the weird thing is that it seems the OTIO has their own testing pipeline that hasn't picked up the error. Could be something to do with how OpenRV is building Python. |
Alternatively requirements.tx would just use pypi instead of git directly. (without the pinning) |
Signed-off-by: Jimmy Christensen <[email protected]>
@cedrik-fuoco-adsk I found out that it was the absolute latest commit that breaks it. The one before doesn't have the issue and I have pinned it to that instead. Also, I should mention that if I use my system python and install the otio module from latest master it works fine. It only breaks with the custom python build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks you @lithorus !
Has anyone else been able to reproduce the import error? |
Yes we're having the exact same issue now in our internal CICD on Windows. |
FYI, I also tested with a newer version of nanobind (since it seemed related to pybind11) which didn't help either. |
Updating CMake to version 3.31.6 did not work either. So we are merging your PR @lithorus. |
f956acf
into
AcademySoftwareFoundation:main
This pins the OTIO python module to a specific commit since the latest commit doesn't work with the compiled python interpreter.