Update osltoyrenderer.cpp: auto-detect output variable -- doesn't need to be Cout if there's only on #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-detect output variable -- doesn't need to be Cout if there's only one Signed-off-by: lunakhan <[email protected]>
|
lgritz
reviewed
Oct 4, 2024
Comment on lines
+143
to
+150
| const ustring* outputs = &output_vars[0]; | ||
| if (output_vars.size() == 1) { | ||
| outputs = &output_vars[0]; // auto-detect and use the single output | ||
| } else { | ||
| // If there are multiple outputs, you could implement additional logic here | ||
| // to choose between them or provide the user with a choice. | ||
| outputs = &output_vars[0]; // default to the first output | ||
| } |
There was a problem hiding this comment.
I don't understand what's going on here. You set outputs to point to the first element of output_vars. OK. Then if that's the only item in output_vars, you... do it again? But if there are multiple items in output_vars, you... also do the same thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto-detect output variable -- doesn't need to be Cout if there's only one
Description
Tests
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.