Skip to content

Conversation

luzpaz
Copy link

@luzpaz luzpaz commented Sep 7, 2025

Link the Issue(s) this Pull Request is related to.

n/a

Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.

Found via codespell -L bui,fo,thirdparty

Describe the reason for the change: uniformity

Reference associated tests.

n/a

Copy link

linux-foundation-easycla bot commented Sep 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.00%. Comparing base (c0e97b0) to head (7b85e18).
⚠️ Report is 68 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   84.11%   85.00%   +0.88%     
==========================================
  Files         198      181      -17     
  Lines       22241    13074    -9167     
  Branches     4687     1206    -3481     
==========================================
- Hits        18709    11113    -7596     
+ Misses       2610     1778     -832     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 85.00% <100.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/rationalTime.h 95.83% <100.00%> (+1.15%) ⬆️
src/opentime/timeRange.h 98.36% <100.00%> (-0.74%) ⬇️
src/opentimelineio/effect.h 83.33% <ø> (-16.67%) ⬇️
...elineio/opentimelineio/algorithms/timeline_algo.py 100.00% <ø> (ø)
...-opentimelineio/opentimelineio/console/otiotool.py 65.72% <100.00%> (-0.59%) ⬇️
.../py-opentimelineio/opentimelineio/core/__init__.py 83.01% <ø> (-0.32%) ⬇️

... and 133 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b3ece1...7b85e18. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jminor
Copy link
Collaborator

jminor commented Sep 9, 2025

@luzpaz I merged in the latest from main to resolve the build issues you hit before. The only outstanding issue to fix is the DCO check. You can see how to resolve that here: https://github.com/AcademySoftwareFoundation/OpenTimelineIO/pull/1936/checks?check_run_id=49903144636

jminor and others added 5 commits September 10, 2025 13:46
* Added otiotool tutorial documentation
* Improved otiotool usage & argument validation

Signed-off-by: Joshua Minor <[email protected]>
Signed-off-by: luzpaz <[email protected]>
Found via `codespell -L bui,fo,thirdparty`

Signed-off-by: luzpaz <[email protected]>
…n#1935)

* Remove MinGW CI jobs

Signed-off-by: Darby Johnston <[email protected]>

* Comment out the MinGW job

Signed-off-by: Darby Johnston <[email protected]>

* Try just disabling the check-manifest and lint check

Signed-off-by: Darby Johnston <[email protected]>

* Add comment

Signed-off-by: Darby Johnston <[email protected]>

---------

Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: luzpaz <[email protected]>
…#1939)

* Only have dependabot check monthly

Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: luzpaz <[email protected]>
@luzpaz
Copy link
Author

luzpaz commented Sep 10, 2025

Oh man, I fubar'd this PR up 😞

@jminor
Copy link
Collaborator

jminor commented Sep 10, 2025

Haha. Yeah, it's "fun with git" day today :)

We can still make this work. When we do land this PR we will squash it like we do to all the other commits into main. If you can do an interactive rebase of your branch onto the latest main, keeping just your one commit that you want to keep, that should resolve these issues. If you haven't done that before, lmk and I can help find a tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants