Skip to content

Conversation

@meshula
Copy link
Collaborator

@meshula meshula commented Oct 28, 2025

Link the Issue(s) this Pull Request is related to.

Fixes 1963

Summarize your change.

Let's be proud of the work and call it mature!!!!

Reference associated tests.

Wide deployment and active development, a responsive user and development community are the "test" that has been fulfilled.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.10%. Comparing base (c0e97b0) to head (879b058).
⚠️ Report is 81 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   84.11%   85.10%   +0.98%     
==========================================
  Files         198      181      -17     
  Lines       22241    12768    -9473     
  Branches     4687     1206    -3481     
==========================================
- Hits        18709    10866    -7843     
+ Misses       2610     1719     -891     
+ Partials      922      183     -739     
Flag Coverage Δ
py-unittests 85.10% <ø> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 131 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60171a4...879b058. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darbyjohnston
Copy link
Contributor

I like the changes, but referencing v1 might be a little confusing? Maybe change:

The API for OpenTimelineIO v1 is considered stable

To:

The current API for OpenTimelineIO is considered stable

@meshula
Copy link
Collaborator Author

meshula commented Oct 28, 2025

@darbyjohnston okay done!! The alternative is that we declare version 1.0 ;)

@darbyjohnston
Copy link
Contributor

I would also be fine with that change, but last time I brought it up there didn't seem to be much enthusiasm for it. :)

@darbyjohnston
Copy link
Contributor

Looks like the DCO just needs to be updated.

Signed-off-by: Nick Porcino <[email protected]>
@meshula
Copy link
Collaborator Author

meshula commented Nov 4, 2025

one day, year, decade,,,,, I will get used to a DCO based workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants