Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java version on opencue base ci image #223

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

DiegoTavares
Copy link
Contributor

Sonarqube now requires java17 to run on top of JacocoTest. Opencue's latest release is compatible with jdk17 so updating the base image should be harmless.

Sonarqube now requires java17 to run on top of JacocoTest. Opencue's latest release is compatible with jdk17 so updating the base image should be harmless. 

Signed-off-by: Diego Tavares <[email protected]>
Copy link
Contributor

@jfpanisset jfpanisset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jfpanisset
Copy link
Contributor

Do you prefer me to:

  • re-release existing 2024.1 ci-opencue image, will pick up a few newer things than the other 2024.1 images but should otherwise be mostly the same

or

  • wait until I release 2024.2 images (have a few more things I want to get in there)

@jfpanisset jfpanisset merged commit 46da5f1 into AcademySoftwareFoundation:main Oct 4, 2024
1 of 3 checks passed
@jfpanisset
Copy link
Contributor

Drats forgot: the ci-opencue/image.yaml file is a source file from which the ci-opencue/Dockerfile and ci-opencue/README.md files are (not auto) generated.

So you'll need to run aswfdocker dockergen to update those files and submit a follow up PR with commits of those files.

If you are having issues doing that, let me know and I can submit a PR on your behalf.

jfpanisset added a commit to jfpanisset/aswf-docker that referenced this pull request Oct 5, 2024
Follow up to PR AcademySoftwareFoundation#223: run `aswfdocker dockergen` to
update ci-opencue

Signed-off-by: Jean-Francois Panisset <[email protected]>
@jfpanisset
Copy link
Contributor

This is addressed in [PR #224]

jfpanisset added a commit that referenced this pull request Oct 5, 2024
Follow up to PR #223: run `aswfdocker dockergen` to
update ci-opencue

Signed-off-by: Jean-Francois Panisset <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants