Update SonarCloud job to install latest sonar-scanner and build-wrapper using a github action #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cary-ilm
reviewed
May 12, 2023
| @@ -7,10 +7,14 @@ | |||
| name: Analysis | |||
|
|
|||
| on: | |||
| schedule: | |||
| # schedule: | |||
There was a problem hiding this comment.
Is there a reason to leave this in but commented out? This change means the analysis will run on each pull request, not just weekly, right? Seems ok to give that a try at least.
There was a problem hiding this comment.
Yes this pull request wasn't ready to merge - I had just issued it to try to test this workflow which is why I commented out the schedule, I was hoping it would run upon pull request. But it didn't seem to work so I still need to try pushing a separate branch temporarily.
|
@xlietz, does this seem to resolve the issues? Good to go? |
|
@cary-ilm I'm still testing this - I will leave a comment when it's ready. Thanks! |
xlietz
force-pushed
the
sonarcloud-update
branch
4 times, most recently
from
c920e36
to
fd63a4d
Compare
build-wrapper. Signed-off-by: Christina Tempelaar-Lietz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Not ready for review - still testing this PR! I submitted this to test my changes since the Sonar scan has to be run on the ASWF repo to work properly.
Updating the SonarCloud job to get the latest sonar-scanner and build-wrapper by using a github action instead of using the versions in the docker image. @cary-ilm noticed that the SonarCloud analysis is generating a warning that the build wrapper version does not match the analyzer version.