Add comment about thread-safety when OPENEXR_ENABLE_THREADING is disabled #1908
Conversation
Signed-off-by: Darby Johnston <[email protected]>
| @@ -40,7 +40,8 @@ set(IEX_NAMESPACE "Iex" CACHE STRING "Public namespace alias for Iex") | |||
| option(OPENEXR_INSTALL_PKG_CONFIG "Install OpenEXR.pc file" ON) | |||
|
|
|||
| # Whether to enable threading. This can be disabled, although thread pool and tasks | |||
| # are still used, just processed immediately | |||
There was a problem hiding this comment.
@kdt3rd, I think the existing comment although thread pool and tasks are still used is no longer true, right? Even if ENABLE_THREADING is ON, then no threadpool is created unless setGlobalThreadCount(n) is called with nonzero n, but OpenEXR will still be thread-safe. I think this what was originally wanted in #1902. ENABLE_THREADING should only be set to OFF on systems which do not support threading
There was a problem hiding this comment.
oh, it is still true technically, in that there is a "default" thread pool that has no threads running. And the writing classes will still add tasks to that threadpool until the next significant release even when threads == 0 (where when threads == 0, the reading classes don't incur that overhead. However yes, ENABLE_THREADING should be on for 99% of use cases, especially now that pthread and such are just part of libc on most systems, and only reserved for use on systems where no threading primitives are available, or threads are guaranteed to not be employed as it makes the library non-reentrant and non-threadsafe
This PR adds a small comment about thread-safety when the cmake option
OPENEXR_ENABLE_THREADINGis disabled.This addresses the crash I found here:
#1902