Skip to content

Conversation

SitiSchu
Copy link
Contributor

@SitiSchu SitiSchu commented Apr 8, 2025

Fixes #1493

This will skip the permission checks before deleting a directory since they don't seem to work on Windows.
Also, if we're deleting a folder the permissions aren't really that important.

@SitiSchu SitiSchu requested a review from a team as a code owner April 8, 2025 08:08
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.78%. Comparing base (fca0b86) to head (cd23839).

Files with missing lines Patch % Lines
src/rez/utils/filesystem.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
- Coverage   60.01%   59.78%   -0.24%     
==========================================
  Files         163      163              
  Lines       20098    20003      -95     
  Branches     3494     3492       -2     
==========================================
- Hits        12062    11958     -104     
- Misses       7224     7229       +5     
- Partials      812      816       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SitiSchu SitiSchu force-pushed the 1493_win_pkg_cache_issue branch from b04858c to e318ce3 Compare April 8, 2025 08:11
@SitiSchu SitiSchu force-pushed the 1493_win_pkg_cache_issue branch from 3e0eb0a to 9ad741a Compare September 11, 2025 12:10
@SitiSchu SitiSchu force-pushed the 1493_win_pkg_cache_issue branch from 9ad741a to cd23839 Compare September 11, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package cache fails to delete on Windows due to .git folder
1 participant