Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override storage fee #2679

Merged
merged 10 commits into from
Jan 10, 2024
Merged

Override storage fee #2679

merged 10 commits into from
Jan 10, 2024

Conversation

wangjj9219
Copy link
Member

resolve #2667

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (f1b2334) 67.53% compared to head (d38202d) 67.77%.
Report is 6 commits behind head on master.

Files Patch % Lines
modules/transaction-payment/src/lib.rs 60.60% 26 Missing ⚠️
modules/support/src/dex.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
+ Coverage   67.53%   67.77%   +0.23%     
==========================================
  Files          71       68       -3     
  Lines        9254     9305      +51     
==========================================
+ Hits         6250     6306      +56     
+ Misses       3004     2999       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangjj9219 wangjj9219 marked this pull request as ready for review December 17, 2023 15:31
xlc
xlc previously approved these changes Dec 19, 2023
@xlc xlc requested a review from zjb0807 December 19, 2023 02:38
zjb0807
zjb0807 previously approved these changes Dec 20, 2023
xlc
xlc previously approved these changes Jan 8, 2024
@xlc xlc enabled auto-merge (squash) January 10, 2024 02:55
xlc
xlc previously approved these changes Jan 10, 2024
@xlc xlc merged commit 3b389e5 into master Jan 10, 2024
6 checks passed
@xlc xlc deleted the override-storage-fee branch January 10, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the payment logic of handling fees
3 participants