Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verify the eth tip #2864

Merged
merged 3 commits into from
Feb 14, 2025
Merged

fix: verify the eth tip #2864

merged 3 commits into from
Feb 14, 2025

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Feb 14, 2025

In module_evm::Call::eth_call:

  • legacy/eip2930 should check the tip
  • eip1559, the tip was encoded in max_priority_fee_per_gas
  • eip712, the tip was included in data

In module_evm::Call::eth_call_v2:

  • the tip was encoded in gas_price , so it's safe.

@zjb0807 zjb0807 requested a review from xlc February 14, 2025 02:07
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (41a10b7) to head (58e9fd0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
primitives/src/unchecked_extrinsic.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2864      +/-   ##
==========================================
+ Coverage   61.19%   61.56%   +0.37%     
==========================================
  Files          65       69       +4     
  Lines        8937    10338    +1401     
==========================================
+ Hits         5469     6365     +896     
- Misses       3468     3973     +505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjb0807 zjb0807 merged commit 0cec34d into master Feb 14, 2025
7 checks passed
@zjb0807 zjb0807 deleted the fix-eip2930 branch February 14, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants