Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/2035 deploy asset fails if pre existing cbbk dependencies are not also deployed #2051

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Bug/2035 deploy asset fails if pre existing cbbk dependencies are not also deployed #2051

merged 5 commits into from
Feb 5, 2025

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Feb 5, 2025 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/asset COMPONENT label Feb 5, 2025
@JoernBerkefeld JoernBerkefeld added this to the 7.7.0 milestone Feb 5, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Feb 5, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 5, 2025
@JoernBerkefeld JoernBerkefeld linked an issue Feb 5, 2025 that may be closed by this pull request
[BUG] deploy asset fails if pre-existing CBBK-dependencies are not also deployed #2035
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Coverage Report

Commit:a425c26
Base: develop@5b3399a

Type Base This PR
Total Statements Coverage  70.58%  70.78%  (+0.2%)
Total Branches Coverage  69.7%  69.91%  (+0.21%)
Total Functions Coverage  83.47%  83.75%  (+0.28%)
Total Lines Coverage  70.58%  70.78%  (+0.2%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Asset.js  79.05%  69.41%  89.58%  79.05%
lib/util/replaceContentBlockReference.js  97.14%  91.22%  100%  97.14%

@JoernBerkefeld JoernBerkefeld merged commit 5b64b44 into develop Feb 5, 2025
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/2035-deploy-asset-fails-if-pre-existing-cbbk-dependencies-are-not-also-deployed branch February 5, 2025 17:45
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Closed
2 tasks
@JoernBerkefeld JoernBerkefeld mentioned this pull request Feb 5, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.

[BUG] deploy asset fails if pre-existing CBBK-dependencies are not also deployed
1 participant
@JoernBerkefeld