Downloader: use truststore for system cert trust when available #1177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with the proxy support, one can easily hit resigning proxies with the model downloader, and naturally
certifi
does not come with support or a way to inject support for arbitrary PKI solutions.Truststore is an elegant way around this problem, it lets one trust the system certificate store instead of certifi: https://pypi.org/project/truststore/
I find the "just capture all things TLS" pattern the neatest if truststore is installed, but I'm open for debate on the implementation details.
https://truststore.readthedocs.io/en/latest/index.html#using-truststore-with-aiohttp