Positive prompts in custom workflows should honor the prompt_line_count setting #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for concise _job_info()" This reverts commit 3947b3f.
mmuellerdm
changed the title
You can rebase/squash them if you want, but Github can also do it when merging so no worries. You might want to run |
|
It looked to me like the lack of type check on update was an obvious oversight, but it turns out it's actually not necessary? I have no idea why, to be honest. I suppose it can't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1415
Sorry for the revert commit, I've had some trouble with branches.