Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samplers: euler, euler a #233

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Add samplers: euler, euler a #233

merged 1 commit into from
Dec 23, 2023

Conversation

sejoung
Copy link
Contributor

@sejoung sejoung commented Dec 14, 2023

Added sampler, Euler, Euler a

@Acly
Copy link
Owner

Acly commented Dec 20, 2023

Out of interest, why would you choose Euler/EulerA over existing alternatives? What is the trade-off?

@sejoung
Copy link
Contributor Author

sejoung commented Dec 21, 2023

We determined that using the image as-is for generation was not feasible. Therefore, we focused on finding high-quality images that are easy to modify. After testing various samplers, we concluded that Euler A is suitable. It would be great if you could confirm with the attached image below And also #117 issue seems to have an additional request in the comments

original

original

euler

euler

DPM++2MSDE Karras

DPM++2MSDE Karras

euler a

eulera

@Acly Acly merged commit b8b850b into Acly:main Dec 23, 2023
2 checks passed
@Acly
Copy link
Owner

Acly commented Dec 23, 2023

Thanks, I agree it looks better in this case. It's just difficult to provide guidance on which samplers to choose, and there are a lot of options. Euler is still popular it seems.

@sejoung sejoung deleted the add_samplers branch January 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants